linux-kernel - Re: [PATCH 0/4] Fix a segmentation fault also add raid6test for RISC-V support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d7dad19-bf05-4109-93ac-7d688b390e1c@ghiti.fr>
Date: Thu, 10 Jul 2025 09:45:25 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Chunyan Zhang <zhang.lyra@...il.com>
Cc: Chunyan Zhang <zhangchunyan@...as.ac.cn>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Charlie Jenkins <charlie@...osinc.com>, Song Liu <song@...nel.org>,
 Yu Kuai <yukuai3@...wei.com>, linux-riscv@...ts.infradead.org,
 linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Fix a segmentation fault also add raid6test for
 RISC-V support

On 7/10/25 03:44, Chunyan Zhang wrote:
> Hi Alex,
>
> On Wed, 9 Jul 2025 at 23:18, Alexandre Ghiti <alex@...ti.fr> wrote:
>> Hi Chunyan,
>>
>> Patch 2 was merged via fixes, do you plan on resending a new version for
>> 6.17 that takes into account Palmer's remarks?
> Yes, I'm preparing the patches these days, just haven't figured out
> how to set NSIZE properly for user space.


Just use hwprobe() to make sure V is supported and then csr_read(VLENB) 
to retrieve this value, no?


>
> I probably should split the patchset, send out one today.
>
> Thanks,
> Chunyan
>
>> Thanks,
>>
>> Alex
>>
>> On 6/10/25 12:12, Chunyan Zhang wrote:
>>> The first two patches are fixes.
>>> The last two are for userspace raid6test support on RISC-V.
>>>
>>> The issue fixed in patch 2/4 was probably the same which was spotted by
>>> Charlie [1], I couldn't reproduce it at that time.
>>>
>>> When running raid6test in userspace on RISC-V, I saw a segmentation fault,
>>> I used gdb command to print pointer p, it was an unaccessible address.
>>>
>>> With patch 2/4, the issue didn't appear anymore.
>>>
>>> [1] https://lore.kernel.org/lkml/Z5gJ35pXI2W41QDk@ghost/
>>>
>>> Chunyan Zhang (4):
>>>     raid6: riscv: clean up unused header file inclusion
>>>     raid6: riscv: Fix NULL pointer dereference issue
>>>     raid6: riscv: Allow code to be compiled in userspace
>>>     raid6: test: add support for RISC-V
>>>
>>>    lib/raid6/recov_rvv.c   |  9 +-----
>>>    lib/raid6/rvv.c         | 62 +++++++++++++++++++++--------------------
>>>    lib/raid6/rvv.h         | 15 ++++++++++
>>>    lib/raid6/test/Makefile |  8 ++++++
>>>    4 files changed, 56 insertions(+), 38 deletions(-)
>>>