linux-kernel - Re: [PATCH 2/3] drm/bridge: select_bus_fmt_recursive(): put the bridge obtained by drm_bridge_get_prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a599626ffe0fff92bead9f693c1a0090@kernel.org>
Date: Thu, 10 Jul 2025 07:54:45 +0000
From: "Maxime Ripard" <mripard@...nel.org>
To: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, "Andrzej
 Hajda" <andrzej.hajda@...el.com>, "David Airlie" <airlied@...il.com>, "Hui
 Pu" <Hui.Pu@...ealthcare.com>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Jonas
 Karlman" <jonas@...boo.se>, "Laurent Pinchart" <Laurent.pinchart@...asonboard.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>, "Neil
 Armstrong" <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>, "Simona
 Vetter" <simona@...ll.ch>, "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>, "Thomas
 Zimmermann" <tzimmermann@...e.de>
Subject: Re: [PATCH 2/3] drm/bridge: select_bus_fmt_recursive(): put the
 bridge obtained by drm_bridge_get_prev_bridge()

On Wed, 9 Jul 2025 17:59:38 +0200, Luca Ceresoli wrote:
> The bridge returned by drm_bridge_get_prev_bridge() is refcounted. Put it
> when done.
> 
> select_bus_fmt_recursive() has several return points, and ensuring
> drm_bridge_put() is always called in the right place would be error-prone
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime