linux-kernel - Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio amplifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1817574C54F0A79C+aG9zl_ERp5hbxwer@foursemi.com>
Date: Thu, 10 Jul 2025 16:02:31 +0800
From: Nick Li <nick.li@...rsemi.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, perex@...ex.cz,
	tiwai@...e.com, xiaoming.yang@...rsemi.com,
	danyang.zheng@...rsemi.com, like.xy@...mail.com,
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio
 amplifiers

On Wed, Jul 09, 2025 at 12:42:35PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Jul 08, 2025 at 07:28:59PM +0800, Nick Li wrote:
> > Add a DT schema for describing FourSemi FS2104/5S
> > audio amplifiers which support both I2S and I2C interface.
> > 
> 
> Another unexpected change from v1: subject: why did you add "schema"?
> 
> I asked to drop it and gave you reference explaining this. Did you read
> it?
> 
> So again, same template:
> 
> A nit, subject: drop second/last, redundant "schema for". The
> "dt-bindings" prefix is already stating that these are bindings in
> schema format, because they cannot be anything else.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 

Sorry, I misunderstood, I will fix it by dropping "schema for ".

Best regards,
Nick

> Best regards,
> Krzysztof
> 
>