linux-kernel - Re: [PATCH v12 11/22] crypto: amlogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aG905asYccnkO3P1@gondor.apana.org.au>
Date: Thu, 10 Jul 2025 20:08:05 +1200
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Alexey Romanov <romanov.alexey2000@...il.com>
Cc: neil.armstrong@...aro.org, clabbe@...libre.com, davem@...emloft.net,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	khilman@...libre.com, jbrunet@...libre.com,
	martin.blumenstingl@...glemail.com, linux-crypto@...r.kernel.org,
	linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v12 11/22] crypto: amlogic - Introduce hasher

On Tue, Jun 24, 2025 at 04:52:03PM +0300, Alexey Romanov wrote:
>
> +static int meson_fill_partial_buffer(struct hasher_ctx *ctx, unsigned int len)
> +{

Please use the new partial block API which removes the need to
handle partial blocks.  See aspeed for an example.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt