linux-kernel - Re: [PATCH] irqchip: irq-msi-lib: fix build with PCI disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86ikk0a2l4.wl-maz@kernel.org>
Date: Thu, 10 Jul 2025 09:10:15 +0100
From: Marc Zyngier <maz@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Arnd Bergmann <arnd@...db.de>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: irq-msi-lib: fix build with PCI disabled

On Thu, 10 Jul 2025 09:00:12 +0100,
Arnd Bergmann <arnd@...nel.org> wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The armada-370-xp irqchip fails in some randconfig builds because
> of a missing declaration:
> 
> In file included from drivers/irqchip/irq-armada-370-xp.c:23:
> include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> Add a forward declaration for the msi_domain_info structure.
> 
> Fixes: e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  include/linux/irqchip/irq-msi-lib.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/irqchip/irq-msi-lib.h b/include/linux/irqchip/irq-msi-lib.h
> index dd8d1d138544..224ac28e88d7 100644
> --- a/include/linux/irqchip/irq-msi-lib.h
> +++ b/include/linux/irqchip/irq-msi-lib.h
> @@ -17,6 +17,7 @@
>  
>  #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
>  
> +struct msi_domain_info;
>  int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
>  			      enum irq_domain_bus_token bus_token);
>  

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.