linux-kernel - Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250710084910.2093426-1-s.taishi14142@gmail.com>
Date: Thu, 10 Jul 2025 17:49:08 +0900
From: Taishi Shimizu <s.taishi14142@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Taishi Shimizu <s.taishi14142@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Rafal Milecki <zajec5@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com,
	Linus Walleij <linus.walleij@...aro.org>,
	Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP

On Tue, Jul 8, 2025 at 10:34 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On Thu, Jun 26, 2025 at 12:43:15AM +0900, Taishi Shimizu wrote:
> > +	chosen {
> > +		bootargs = "console=ttyS0,115200";
>
> Please use stdout path property.

Thanks for the review. Since `stdout-path` is already defined in
`bcm4708.dtsi`, I removed the `chosen` node from the board DTS.

> +		leds {
> +			compatible = "gpio-leds";
> +
> > +		led-power0 {
> > +			label = "bcm53xx:white:power";
>
> You should use rather color and function properties.

I replaced all `label` properties in the LED definitions with `color` and
`function` properties as appropriate.

I'll send v2 accordingly. Thanks!

Best regards,  
Taishi Shimizu