linux-kernel - Re: [PATCH] cachefiles: Fix the incorrect return value in __cachefiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <886b55b4-162f-4acd-a5ec-6114e6239a89@huaweicloud.com>
Date: Thu, 10 Jul 2025 09:10:48 +0800
From: Zizhi Wo <wozizhi@...weicloud.com>
To: David Howells <dhowells@...hat.com>, Zizhi Wo <wozizhi@...weicloud.com>
Cc: netfs@...ts.linux.dev, jlayton@...nel.org, brauner@...nel.org,
 linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 libaokun1@...wei.com, yangerkun@...wei.com, houtao1@...wei.com,
 yukuai3@...wei.com
Subject: Re: [PATCH] cachefiles: Fix the incorrect return value in
 __cachefiles_write()

在 2025/7/10 0:03, David Howells 写道:
> I think this should only affect erofs, right?
> 
> David
> 
> 

Yes, currently other callers don't rely on the return value of
__cachefiles_write(); instead, they determine success or failure through
cachefiles_write_complete().

Therefore, resetting "ret" to 0 in __cachefiles_write() might be
unnecessary? When this step is removed, the outer
cachefiles_ondemand_fd_write_iter() can also correctly update the offset
based on ret.

Thanks,
Zizhi Wo