linux-kernel - RE: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire system_counterval_t in get_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986B554A8E1383F3D94DD58E548A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 10 Jul 2025 10:33:56 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Simon Horman <horms@...nel.org>, Markus Blöchl
	<markus@...chl.de>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Richard Cochran <richardcochran@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>, Lakshmi Sowjanya D
	<lakshmi.sowjanya.d@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Bloechl,
 Markus" <markus.bloechl@...tronik.com>, John Stultz <jstultz@...gle.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire
 system_counterval_t in get_time_fn() callback



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Simon Horman
> Sent: Thursday, July 10, 2025 12:25 PM
> To: Markus Blöchl <markus@...chl.de>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Richard Cochran
> <richardcochran@...il.com>; Thomas Gleixner <tglx@...utronix.de>;
> Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Bloechl, Markus
> <markus.bloechl@...tronik.com>; John Stultz <jstultz@...gle.com>;
> intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH v2] e1000e: Populate entire
> system_counterval_t in get_time_fn() callback
> 
> On Wed, Jul 09, 2025 at 07:28:07PM +0200, Markus Blöchl wrote:
> > get_time_fn() callback implementations are expected to fill out the
> > entire system_counterval_t struct as it may be initially
> uninitialized.
> >
> > This broke with the removal of convert_art_to_tsc() helper functions
> > which left use_nsecs uninitialized.
> >
> > Assign the entire struct again.
> >
> > Fixes: bd48b50be50a ("e1000e: Replace convert_art_to_tsc()")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Markus Blöchl <markus@...chl.de>
> > ---
> > Notes:
> >     Related-To:
> >
> <https://lore.kernel.org/lkml/txyrr26hxe3xpq3ebqb5ewkgvhvp7xalotaouwlu
> > djtjifnah2@...gczln4aoo/>
> >
> > Changes in v2:
> > - Add Lakshmi in Cc:
> > - Add Signed-off-by: trailer which was lost in b4 workflow
> > - Link to v1:
> > https://lore.kernel.org/r/20250709-e1000e_crossts-v1-1-
> f8a80c792e4f@bl
> > ochl.de
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>