linux-kernel - Re: [PATCH v6 02/21] cpu: Define attack vectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250710104252.GBaG-ZLG7p_LsNCjBm@fat_crate.local>
Date: Thu, 10 Jul 2025 12:42:52 +0200
From: Borislav Petkov <bp@...en8.de>
To: David Kaplan <david.kaplan@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 02/21] cpu: Define attack vectors

On Mon, Jul 07, 2025 at 01:32:57PM -0500, David Kaplan wrote:
> +	/* Attack vector controls may come after a ';' */
> +	if (*p++ != ';' || !IS_ENABLED(CONFIG_ARCH_HAS_CPU_ATTACK_VECTORS)) {

Right, so the ; separator causes problems with grub and its shell-like
grub.cfg file. If I put there:

	... mitigations=auto;no_guest_host

it says

	error: can't find command `no_guest_host'.

because it thinks it is a bash command.

We could do

	... 'mitigations=auto;no_guest_host'

but that's non-intuitive and it'll cause problems left'n'right.

Using ':' as a separator instead seems to work so if people agree, I'd switch
to ':'...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette