linux-kernel - Re: [PATCH 01/10] mm/mremap: perform some simple cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <841160e5-4ae2-4e8d-b2dc-aa93f17a5c00@suse.cz>
Date: Thu, 10 Jul 2025 13:09:34 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Peter Xu <peterx@...hat.com>, Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Jann Horn <jannh@...gle.com>,
 Pedro Falcato <pfalcato@...e.de>, Rik van Riel <riel@...riel.com>,
 linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 01/10] mm/mremap: perform some simple cleanups

On 7/7/25 07:27, Lorenzo Stoakes wrote:
> We const-ify the vrm flags parameter to indicate this will never change.
> 
> We rename resize_is_valid() to remap_is_valid(), as this function does not
> only apply to cases where we resize, so it's simply confusing to refer to
> that here.
> 
> We remove the BUG() from mremap_at(), as we should not BUG() unless we are
> certain it'll result in system instability.
> 
> We rename vrm_charge() to vrm_calc_charge() to make it clear this simply
> calculates the charged number of pages rather than actually adjusting any
> state.
> 
> We update the comment for vrm_implies_new_addr() to explain that
> MREMAP_DONTUNMAP does not require a set address, but will always be moved.
> 
> Additionally consistently use 'res' rather than 'ret' for result values.
> 
> No functional change intended.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>