linux-kernel - Re: [PATCH] platform/x86: lenovo: gamezone needs "other mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd727ab6-a754-77fd-5876-fec076c8905a@linux.intel.com>
Date: Fri, 11 Jul 2025 17:55:50 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Arnd Bergmann <arnd@...nel.org>, 
    "Derek J. Clark" <derekjohn.clark@...il.com>
cc: Mark Pearson <mpearson-lenovo@...ebb.ca>, Hans de Goede <hansg@...nel.org>, 
    Armin Wolf <W_Armin@....de>, Arnd Bergmann <arnd@...db.de>, 
    Alok Tiwari <alok.a.tiwari@...cle.com>, 
    Mario Limonciello <mario.limonciello@....com>, 
    Jelle van der Waa <jvanderwaa@...hat.com>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: lenovo: gamezone needs "other mode"

On Wed, 9 Jul 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> Registering the "other mode" notifier fails if that is disabled:
> 
> x86_64-linux-ld: drivers/platform/x86/lenovo/wmi-gamezone.o: in function `lwmi_gz_probe':
> wmi-gamezone.c:(.text+0x336): undefined reference to `devm_lwmi_om_register_notifier'
> 
> This could be fixed by adding a stub helper, but a Kconfig 'select'
> seems simpler here.
> 
> Fixes: 22024ac5366f ("platform/x86: Add Lenovo Gamezone WMI Driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/platform/x86/lenovo/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/lenovo/Kconfig b/drivers/platform/x86/lenovo/Kconfig
> index b76157b35296..e9e1c3268373 100644
> --- a/drivers/platform/x86/lenovo/Kconfig
> +++ b/drivers/platform/x86/lenovo/Kconfig
> @@ -250,8 +250,7 @@ config LENOVO_WMI_GAMEZONE
>  	depends on ACPI_WMI
>  	depends on DMI
>  	select ACPI_PLATFORM_PROFILE
> -	select LENOVO_WMI_EVENTS
> -	select LENOVO_WMI_HELPERS
> +	select LENOVO_WMI_TUNING

Why did you remove the other two?

Do select propagate properly these days across another select? I was under 
impression they don't which is one of the reasons use of select is 
discouraged.

-- 
 i.