linux-kernel - Re: [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHEw1U8x5WfGaMsC@U-2FWC9VHC-2323.local>
Date: Fri, 11 Jul 2025 23:42:13 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Petr Mladek <pmladek@...e.com>
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a
 compilation issue

On Fri, Jul 11, 2025 at 03:13:09PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 11, 2025 at 12:51:06PM +0300, Andy Shevchenko wrote:
> > While targeting the compilation issue due to dangling variable,
> > I have noticed more opportunities for refactoring that helps to
> > avoid above mentioned compilation issue and make code cleaner in
> > general. Please, give it a try.
> > 
> > I put a revert as the first patch of the previous solution, but I believe
> > the previous solution may be pulled out without a problem.
> 
> Btw, I can try to pop the fix upper in the series, but since this
> whole feature was only a few days old, I propose to drop it completely
> for now and start again. Please, Cc me for the review.

Can we just take your fix and nice cleanups? Do we really need to drop
the whole series? My gcc haven't raised warnings in the past several
versions, and I will install clang for more complete compiling test
beside functional test for future patches.

Anyway I don't think it has fundamental blocking issue, but I'm fine
if you insist to do so.

Thanks,
Feng

> -- 
> With Best Regards,
> Andy Shevchenko
>