linux-kernel - Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com>
Date: Fri, 11 Jul 2025 18:15:52 +0200
From: David Hildenbrand <david@...hat.com>
To: Chi Zhiling <chizhiling@....com>, willy@...radead.org,
 akpm@...ux-foundation.org
Cc: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Chi Zhiling <chizhiling@...inos.cn>,
 Ryan Roberts <ryan.roberts@....com>
Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift
 operation

On 10.07.25 08:04, Chi Zhiling wrote:
> From: Chi Zhiling <chizhiling@...inos.cn>
> 
> folio_nr_pages() is faster helper function to get the number of pages
> when NR_PAGES_IN_LARGE_FOLIO is enabled.
> 
> Signed-off-by: Chi Zhiling <chizhiling@...inos.cn>
> ---
>   mm/readahead.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/readahead.c b/mm/readahead.c
> index 95a24f12d1e7..406756d34309 100644
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control *ractl,
>   	 * Ramp up sizes, and push forward the readahead window.
>   	 */
>   	expected = round_down(ra->start + ra->size - ra->async_size,
> -			1UL << folio_order(folio));
> +			folio_nr_pages(folio));
>   	if (index == expected) {
>   		ra->start += ra->size;
>   		/*

This should probably get squashed in Ryans commit?

LGTM

-- 
Cheers,

David / dhildenb