linux-kernel - Re: [PATCH v1 7/7] panic: sys_info: Factor out read and write handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHE9EEbsCuDOfD3J@smile.fi.intel.com>
Date: Fri, 11 Jul 2025 19:34:24 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Feng Tang <feng.tang@...ux.alibaba.com>
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH v1 7/7] panic: sys_info: Factor out read and write
 handlers

On Fri, Jul 11, 2025 at 11:09:16PM +0800, Feng Tang wrote:
> On Fri, Jul 11, 2025 at 12:51:13PM +0300, Andy Shevchenko wrote:
> > For the sake of the code readability and easier maintenance
> > factor out read and write sys_info handlers.
> 
> IIRC, I did implement separate 'write' handler, but chose not
> to do that to save some common definition. I guess it's personal
> preference, and I'm fine with either one. 

It looks better, in my opinion, to be three functions.

-- 
With Best Regards,
Andy Shevchenko