linux-kernel - Re: [PATCH v6 0/3] Fix wrong dpa checking in PPR operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <221d5666-a860-40c0-8cab-9c8086c1a597@intel.com>
Date: Fri, 11 Jul 2025 09:57:38 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Li Ming <ming.li@...omail.com>, dave@...olabs.net,
 jonathan.cameron@...wei.com, alison.schofield@...el.com,
 vishal.l.verma@...el.com, ira.weiny@...el.com, dan.j.williams@...el.com,
 shiju.jose@...wei.com
Cc: andriy.shevchenko@...ux.intel.com, linux-cxl@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/3] Fix wrong dpa checking in PPR operation



On 7/10/25 8:23 PM, Li Ming wrote:
> In cxl_do_ppr(), there is a checking to check if a DPA is valid, the
> implementation of the checking is check if the DPA is 0, if yes,
> consider that DPA is valid. the checking is not right, the correct
> implementation is checking if the DPA is in the CXL device DPA range, if
> yes, it is valid.
> 
> The patchset also includes another part implementing a general helper
> function cxl_resource_contains_addr() in cxl core so that cxl drivers
> can use it for all DPA/HPA/SPA availability checking.

applied to cxl/next
bdf2d9fd3a86 cxl/core: Using cxl_resource_contains_addr() to check address availability
03ff65c02559 cxl/edac: Fix wrong dpa checking for PPR operation
5b6031c832c2 cxl/core: Introduce a new helper cxl_resource_contains_addr()

> 
> v6:
> - Fix reviewed-by tag mistake.
> 
> v5:
> - Reverse checkings order in cxl_do_ppr(). (Alison)
> 
> v4:
> - Add cxl_ prefix to resource_contains_addr().	(Andy & Alison)
> - Add impact statement to the commit log of Patch #2. (Alison)
> - Add review tags.
> 
> v3:
> - Move resource_contains_addr() from include/linux/ioport.h to
> cxl/core/hdm.c. (Andy)
> 
> v2:
> - Implement a general helper resource_contains_addr() for DPA/HPA
> resource. (Alison)
> 
> base-commit: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af cxl/fixes
> 
> Li Ming (3):
>   cxl/core: Introduce a new helper cxl_resource_contains_addr()
>   cxl/edac: Fix wrong dpa checking for PPR operation
>   cxl/core: Using cxl_resource_contains_addr() to check address
>     availability
> 
>  drivers/cxl/core/core.h   | 1 +
>  drivers/cxl/core/edac.c   | 9 ++++++---
>  drivers/cxl/core/hdm.c    | 7 +++++++
>  drivers/cxl/core/memdev.c | 2 +-
>  drivers/cxl/core/region.c | 6 +++---
>  5 files changed, 18 insertions(+), 7 deletions(-)
>