linux-kernel - Re: [PATCH 4/9] gpio: regmap: add the .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55e7aeb5-565f-4452-bc11-55968dcc0a9e@lunn.ch>
Date: Fri, 11 Jul 2025 19:45:48 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Ioana Ciornei <ioana.ciornei@....com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>,
	Lee Jones <lee@...nel.org>, Frank Li <Frank.Li@....com>
Subject: Re: [PATCH 4/9] gpio: regmap: add the .get_direction() callback

On Fri, Jul 11, 2025 at 07:43:13PM +0200, Linus Walleij wrote:
> On Wed, Jul 9, 2025 at 5:09 PM Andrew Lunn <andrew@...n.ch> wrote:
> 
> > This is not my area, so i will deffer to the GPIO
> > Maintainers. However, it is not clear to me what get_direction()
> > should return.
> 
> This callback should return the current direction as set up
> in the hardware.
> 
> A major usecase is that this is called when the gpiochip is
> registered to read out all the current directions of the GPIO
> lines, so the kernel has a clear idea of the state of the
> hardware.
> 
> Calling this should ideally result in a read of the status from
> a hardware register.

O.K, so completely different to what is proposed in this patch.

Maybe you can suggest a better name.

	Andrew