linux-kernel - RE: [PATCH v4 7/7] iommufd/selftest: Add coverage for vdevice tombstone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB527691DABF03AA1D04B899698C4BA@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Fri, 11 Jul 2025 03:12:52 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
CC: "jgg@...dia.com" <jgg@...dia.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"will@...nel.org" <will@...nel.org>, "aneesh.kumar@...nel.org"
	<aneesh.kumar@...nel.org>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"joro@...tes.org" <joro@...tes.org>, "robin.murphy@....com"
	<robin.murphy@....com>, "shuah@...nel.org" <shuah@...nel.org>,
	"nicolinc@...dia.com" <nicolinc@...dia.com>, "aik@....com" <aik@....com>,
	"Williams, Dan J" <dan.j.williams@...el.com>, "baolu.lu@...ux.intel.com"
	<baolu.lu@...ux.intel.com>, "Xu, Yilun" <yilun.xu@...el.com>
Subject: RE: [PATCH v4 7/7] iommufd/selftest: Add coverage for vdevice
 tombstone

> From: Xu Yilun <yilun.xu@...ux.intel.com>
> Sent: Thursday, July 10, 2025 5:25 PM
> 
> On Thu, Jul 10, 2025 at 08:10:34AM +0000, Tian, Kevin wrote:
> > > From: Xu Yilun <yilun.xu@...ux.intel.com>
> > > Sent: Wednesday, July 9, 2025 12:03 PM
> > >
> > > This tests the flow to tombstone vdevice when idevice is to be unbound
> > > before vdevice destruction. The expected result is:
> > >
> > >  - idevice unbinding tombstones vdevice ID, the ID can't be repurposed
> > >    anymore.
> > >  - Even ioctl(IOMMU_DESTROY) can't free the tombstoned ID.
> > >  - iommufd_fops_release() can still free everything.
> >
> > but the test only checks 2) instead of all?
> 
> It tests 2) & 3), 3) will be executed on
> FIXTURE_TEARDOWN(iommufd_viommu)
> 
> For 1) "the ID can't be repurposed anymore", I don't have a good idea how
> to
> verify it. Allocate 2^32 objects and verify no tombstoned ID is
> reused? That's too crazy...   Maybe just mark it untested in the commit
> message?
> 

not required. Just make the commit msg clear.