[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <64fcf4b7-b5c1-4983-b4e3-c490a461e8a0@zohomail.com>
Date: Fri, 11 Jul 2025 11:19:08 +0800
From: Li Ming <ming.li@...omail.com>
To: linux-cxl@...r.kernel.org
Cc: andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
dan.j.williams@...el.com, shiju.jose@...wei.com
Subject: Re: [PATCH v5 1/3] cxl/core: Introduce a new helper
cxl_resource_contains_addr()
On 7/11/2025 11:10 AM, Li Ming wrote:
> In CXL subsystem, many functions need to check an address availability
> by checking if the resource range contains the address. Providing a new
> helper function cxl_resource_contains_addr() to check if the resource
> range contains the input address.
>
> Suggested-by: Alison Schofield <alison.schofield@...el.com>
> Signed-off-by: Li Ming <ming.li@...omail.com>
> Tested-by: Shiju Jose <shiju.jose@...wei.com>
> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
I added a wrong reviewed-by tag here, it should be for Andy not Alison, Will send another version to fix it.
Ming
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
> drivers/cxl/core/core.h | 1 +
> drivers/cxl/core/hdm.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h
> index 29b61828a847..6b78b10da3e1 100644
> --- a/drivers/cxl/core/core.h
> +++ b/drivers/cxl/core/core.h
> @@ -80,6 +80,7 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, u64 size);
> int cxl_dpa_free(struct cxl_endpoint_decoder *cxled);
> resource_size_t cxl_dpa_size(struct cxl_endpoint_decoder *cxled);
> resource_size_t cxl_dpa_resource_start(struct cxl_endpoint_decoder *cxled);
> +bool cxl_resource_contains_addr(const struct resource *res, const resource_size_t addr);
>
> enum cxl_rcrb {
> CXL_RCRB_DOWNSTREAM,
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index ab1007495f6b..088caa6b6f74 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -547,6 +547,13 @@ resource_size_t cxl_dpa_resource_start(struct cxl_endpoint_decoder *cxled)
> return base;
> }
>
> +bool cxl_resource_contains_addr(const struct resource *res, const resource_size_t addr)
> +{
> + struct resource _addr = DEFINE_RES_MEM(addr, 1);
> +
> + return resource_contains(res, &_addr);
> +}
> +
> int cxl_dpa_free(struct cxl_endpoint_decoder *cxled)
> {
> struct cxl_port *port = cxled_to_port(cxled);
Powered by blists - more mailing lists