linux-kernel - Re: [PATCH 7/8] media: rkvdec: Remove TODO file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f36e0e642a1554f4661f122f7d525d5677ce1df.camel@ndufresne.ca>
Date: Fri, 11 Jul 2025 16:00:39 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Detlev Casanova <detlev.casanova@...labora.com>, 
	linux-kernel@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
  Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Sebastian Reichel	 <sebastian.reichel@...labora.com>, Cristian Ciocaltea	
 <cristian.ciocaltea@...labora.com>, Alexey Charkov <alchark@...il.com>, 
 Dragan Simic <dsimic@...jaro.org>, Jianfeng Liu
 <liujianfeng1994@...il.com>, Nicolas Frattaroli	
 <nicolas.frattaroli@...labora.com>, Kever Yang <kever.yang@...k-chips.com>,
  Andy Yan <andy.yan@...k-chips.com>, Frank Wang
 <frank.wang@...k-chips.com>, 	devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, 	linux-rockchip@...ts.infradead.org,
 Ezequiel Garcia	 <ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab
 <mchehab@...nel.org>,  Hans Verkuil <hverkuil@...all.nl>, Ricardo Ribalda
 <ribalda@...omium.org>, Hans de Goede <hansg@...nel.org>,  Yunke Cao
 <yunkec@...gle.com>, linux-media@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH 7/8] media: rkvdec: Remove TODO file

Le lundi 23 juin 2025 à 12:07 -0400, Detlev Casanova a écrit :
> 2 items are present in the TODO file:
>  - HEVC support
>  - Evaluate adding helper for rkvdec_request_validate
> 
> Missing HEVC support is not a reason for a driver to be in staging,
> support for different features of the hardware can be added in drivers
> in the main tree.
> 
> The rkvdec_request_validate function was simplified in
> commit 54676d5f5630 ("media: rkvdec: Do not require all controls to be present
> in every request")
> by not setting controls that have not changed.
> As it now basically just calls vb2_request_validate(), there is no need
> for a helper.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  drivers/staging/media/rkvdec/TODO | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 drivers/staging/media/rkvdec/TODO
> 
> diff --git a/drivers/staging/media/rkvdec/TODO
> b/drivers/staging/media/rkvdec/TODO
> deleted file mode 100644
> index 2c0779383276e..0000000000000
> --- a/drivers/staging/media/rkvdec/TODO
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -* Support for HEVC is planned for this driver.
> -
> -  Given the V4L controls for that CODEC will be part of
> -  the uABI, it will be required to have the driver in staging.
> -
> -  For this reason, we are keeping this driver in staging for now.
> -
> -* Evaluate introducing a helper to consolidate duplicated
> -  code in rkvdec_request_validate and cedrus_request_validate.
> -  The helper needs to the driver private data associated with
> -  the videobuf2 queue, from a media request.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)