linux-kernel - [PATCH v2 2/2] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711200418.1858682-3-chaitanya.vadrevu@emerson.com>
Date: Fri, 11 Jul 2025 15:04:18 -0500
From: Chaitanya Vadrevu <chaitanya.vadrevu@...rson.com>
To: <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>
CC: <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Chaitanya
 Vadrevu" <chaitanya.vadrevu@...rson.com>,
        Jason Smith
	<jason.smith@...rson.com>,
        Gratian Crisan <gratian.crisan@...rson.com>
Subject: [PATCH v2 2/2] serial: 8250_ni: Reorder local variables

Reorder local variables in ni16550_probe to follow reverse Christmas
tree style.

Cc: Jason Smith <jason.smith@...rson.com>
Cc: Gratian Crisan <gratian.crisan@...rson.com>
Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@...rson.com>
Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
---
 drivers/tty/serial/8250/8250_ni.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_ni.c b/drivers/tty/serial/8250/8250_ni.c
index 81f2255012153..cb5b42b3609c9 100644
--- a/drivers/tty/serial/8250/8250_ni.c
+++ b/drivers/tty/serial/8250/8250_ni.c
@@ -275,12 +275,12 @@ static void ni16550_set_mctrl(struct uart_port *port, unsigned int mctrl)
 
 static int ni16550_probe(struct platform_device *pdev)
 {
+	struct uart_8250_port *uart __free(kfree) = NULL;
 	const struct ni16550_device_info *info;
 	struct device *dev = &pdev->dev;
-	struct uart_8250_port *uart __free(kfree) = NULL;
 	unsigned int txfifosz, rxfifosz;
-	unsigned int prescaler;
 	struct ni16550_data *data;
+	unsigned int prescaler;
 	const char *portmode;
 	bool rs232_property;
 	int ret;
-- 
2.43.0