linux-kernel - Re: [PATCH 0/2] netfs: Fix use of fscache with ceph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <617b207a7cf0b21a2aff2c05c36bfed2@manguebit.org>
Date: Fri, 11 Jul 2025 17:09:00 -0300
From: Paulo Alcantara <pc@...guebit.org>
To: David Howells <dhowells@...hat.com>, Christian Brauner
 <christian@...uner.io>
Cc: David Howells <dhowells@...hat.com>, Max Kellermann
 <max.kellermann@...os.com>, Viacheslav Dubeyko <slava@...eyko.com>, Alex
 Markuze <amarkuze@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
 netfs@...ts.linux.dev, linux-nfs@...r.kernel.org,
 ceph-devel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] netfs: Fix use of fscache with ceph

David Howells <dhowells@...hat.com> writes:

> Hi Christian,
>
> Here are a couple of patches that fix the use of fscaching with ceph:
>
>  (1) Fix the read collector to mark the write request that it creates to copy
>      data to the cache with NETFS_RREQ_OFFLOAD_COLLECTION so that it will run
>      the write collector on a workqueue as it's meant to run in the background
>      and the app isn't going to wait for it.
>
>  (2) Fix the read collector to wake up the copy-to-cache write request after
>      it sets NETFS_RREQ_ALL_QUEUED if the write request doesn't have any
>      subrequests left on it.  ALL_QUEUED indicates that there won't be any
>      more subreqs coming and the collector should clean up - except that an
>      event is needed to trigger that, but it only gets events from subreq
>      termination and so the last event can beat us to setting ALL_QUEUED.
>
> The patches can also be found here:
>
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
>
> Thanks,
> David
>
> David Howells (2):
>   netfs: Fix copy-to-cache so that it performs collection with
>     ceph+fscache
>   netfs: Fix race between cache write completion and ALL_QUEUED being
>     set
>
>  fs/netfs/read_pgpriv2.c      |  5 +++++
>  include/trace/events/netfs.h | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+)

Reviewed-by: Paulo Alcantara (Red Hat) <pc@...guebit.org>