linux-kernel - Re: [PATCH v1] PM: suspend: Drop a misplaced pm_restore_gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6324f224-0c63-402f-8bf9-66386c73909c@amd.com>
Date: Fri, 11 Jul 2025 16:09:27 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
 Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] PM: suspend: Drop a misplaced pm_restore_gfp_mask()
 call

On 7/10/2025 3:43 AM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The pm_restore_gfp_mask() call added by commit 12ffc3b1513e ("PM:
> Restrict swap use to later in the suspend sequence") to
> suspend_devices_and_enter() is done too early because it takes
> place before calling dpm_resume() in dpm_resume_end() and some
> swap-backing devices may not be ready at that point.  Moreover, it
> is not even necessary because dpm_resume_end() called subsequently
> in the same code path invokes that function again.
> 
> Drop the misplaced pm_restore_gfp_mask() call from
> suspend_devices_and_enter() to address this issue.
> 
> Fixes: 12ffc3b1513e ("PM: Restrict swap use to later in the suspend sequence")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   kernel/power/suspend.c |    1 -
>   1 file changed, 1 deletion(-)
> 
> --- a/kernel/power/suspend.c
> +++ b/kernel/power/suspend.c
> @@ -540,7 +540,6 @@
>   	return error;
>   
>    Recover_platform:
> -	pm_restore_gfp_mask();
>   	platform_recover(state);
>   	goto Resume_devices;
>   }
> 
> 
> 

Reviewed-by: Mario Limonciello <mario.limonciello@....com>