linux-kernel - Re: [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_MX6jkkgKTTkZY=M9btZPdVmSSs9siEJ9E8b=tz21MCZw@mail.gmail.com>
Date: Fri, 11 Jul 2025 17:10:59 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Sunil Khatri <sunil.khatri@....com>, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()

On Wed, Jul 9, 2025 at 3:28 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> If kasprintf() fails, some mutex still need to be released to avoid locking
> issue, as already done in all other error handling path.
>
> Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

@Christian Koenig @Sunil Khatri can you pick this up for drm-misc?

Thanks,

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 513bbc543f40..bce97318965c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -520,8 +520,10 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args)
>         }
>
>         queue_name = kasprintf(GFP_KERNEL, "queue-%d", qid);
> -       if (!queue_name)
> -               return -ENOMEM;
> +       if (!queue_name) {
> +               r = -ENOMEM;
> +               goto unlock;
> +       }
>
>         /* Queue dentry per client to hold MQD information   */
>         queue->debugfs_queue = debugfs_create_dir(queue_name, filp->debugfs_client);
> --
> 2.50.0
>