linux-kernel - Re: [PATCH] lib/crypto: arm/poly1305: fix poly1305_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250711213437.GA4300@quark>
Date: Fri, 11 Jul 2025 14:34:37 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Sohil Mehta <sohil.mehta@...el.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: arm/poly1305: fix poly1305_blocks_neon link
 failure

On Fri, Jul 11, 2025 at 09:23:59AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The reference to poly1305_blocks_neon from generated assembler code is
> apparently the reason we had the silly __weak function in the wrapper.
> Removing it introduced a link failure:
> 
> ERROR: modpost: "poly1305_blocks_neon" [lib/crypto/arm/poly1305-arm.ko] undefined!
> 
> Moving the reference inside of the #if ARMv7 block avoids this problem.
> 
> Fixes: 16f9e0cc99ec ("lib/crypto: arm/poly1305: Remove unneeded empty weak function")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I see that the neon code is always built when targetting ARMv7, even in
> configurations without CONFIG_KERNEL_MODE_NEON where it is never called.
> I tried cleaning that up as well but couldn't figure it out.
> ---
>  lib/crypto/arm/poly1305-armv4.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!  That's an interesting one... unfortunately the "perlasm" files
are kind of a mess.

To avoid a bisection hazard, I'm replacing the original patch with an
updated version that includes your fix:
https://lore.kernel.org/r/20250711212822.6372-1-ebiggers@kernel.org

- Eric