| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202507111201.r62j5rb6-lkp@intel.com>
Date: Fri, 11 Jul 2025 12:55:25 +0800
From: kernel test robot <lkp@...el.com>
To: Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
Remi Buisson <remi.buisson@....com>
Subject: Re: [PATCH v2 6/8] iio: imu: inv_icm45600: add SPI driver for
inv_icm45600 driver
Hi Remi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on f8f559752d573a051a984adda8d2d1464f92f954]
url: https://github.com/intel-lab-lkp/linux/commits/Remi-Buisson-via-B4-Relay/dt-bindings-iio-imu-Add-inv_icm45600/20250710-170143
base: f8f559752d573a051a984adda8d2d1464f92f954
patch link: https://lore.kernel.org/r/20250710-add_newport_driver-v2-6-bf76d8142ef2%40tdk.com
patch subject: [PATCH v2 6/8] iio: imu: inv_icm45600: add SPI driver for inv_icm45600 driver
config: mips-randconfig-r072-20250711 (https://download.01.org/0day-ci/archive/20250711/202507111201.r62j5rb6-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250711/202507111201.r62j5rb6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507111201.r62j5rb6-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c:107:7: warning: variable 'sleep' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
107 | if (*scan_mask & (BIT(INV_ICM45600_ACCEL_SCAN_X) |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
108 | BIT(INV_ICM45600_ACCEL_SCAN_Y) |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
109 | BIT(INV_ICM45600_ACCEL_SCAN_Z))) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c:123:6: note: uninitialized use occurs here
123 | if (sleep)
| ^~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c:107:3: note: remove the 'if' if its condition is always true
107 | if (*scan_mask & (BIT(INV_ICM45600_ACCEL_SCAN_X) |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
108 | BIT(INV_ICM45600_ACCEL_SCAN_Y) |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
109 | BIT(INV_ICM45600_ACCEL_SCAN_Z))) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c:100:20: note: initialize the variable 'sleep' to silence this warning
100 | unsigned int sleep;
| ^
| = 0
1 warning generated.
--
>> drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c:107:7: warning: variable 'sleep' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
107 | if (*scan_mask & (BIT(INV_ICM45600_GYRO_SCAN_X) |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
108 | BIT(INV_ICM45600_GYRO_SCAN_Y) |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
109 | BIT(INV_ICM45600_GYRO_SCAN_Z))) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c:121:6: note: uninitialized use occurs here
121 | if (sleep)
| ^~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c:107:3: note: remove the 'if' if its condition is always true
107 | if (*scan_mask & (BIT(INV_ICM45600_GYRO_SCAN_X) |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
108 | BIT(INV_ICM45600_GYRO_SCAN_Y) |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
109 | BIT(INV_ICM45600_GYRO_SCAN_Z))) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/imu/inv_icm45600/inv_icm45600_gyro.c:100:20: note: initialize the variable 'sleep' to silence this warning
100 | unsigned int sleep;
| ^
| = 0
1 warning generated.
vim +107 drivers/iio/imu/inv_icm45600/inv_icm45600_accel.c
1fb5c2bf7348d06 Remi Buisson 2025-07-10 91
1fb5c2bf7348d06 Remi Buisson 2025-07-10 92 /* enable accelerometer sensor and FIFO write */
1fb5c2bf7348d06 Remi Buisson 2025-07-10 93 static int inv_icm45600_accel_update_scan_mode(struct iio_dev *indio_dev,
1fb5c2bf7348d06 Remi Buisson 2025-07-10 94 const unsigned long *scan_mask)
1fb5c2bf7348d06 Remi Buisson 2025-07-10 95 {
1fb5c2bf7348d06 Remi Buisson 2025-07-10 96 struct inv_icm45600_state *st = iio_device_get_drvdata(indio_dev);
1fb5c2bf7348d06 Remi Buisson 2025-07-10 97 struct inv_icm45600_sensor_state *accel_st = iio_priv(indio_dev);
1fb5c2bf7348d06 Remi Buisson 2025-07-10 98 struct inv_icm45600_sensor_conf conf = INV_ICM45600_SENSOR_CONF_INIT;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 99 unsigned int fifo_en = 0;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 100 unsigned int sleep;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 101 int ret;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 102
1fb5c2bf7348d06 Remi Buisson 2025-07-10 103 scoped_guard(mutex, &st->lock) {
1fb5c2bf7348d06 Remi Buisson 2025-07-10 104 if (*scan_mask & BIT(INV_ICM45600_ACCEL_SCAN_TEMP))
1fb5c2bf7348d06 Remi Buisson 2025-07-10 105 fifo_en |= INV_ICM45600_SENSOR_TEMP;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 106
1fb5c2bf7348d06 Remi Buisson 2025-07-10 @107 if (*scan_mask & (BIT(INV_ICM45600_ACCEL_SCAN_X) |
1fb5c2bf7348d06 Remi Buisson 2025-07-10 108 BIT(INV_ICM45600_ACCEL_SCAN_Y) |
1fb5c2bf7348d06 Remi Buisson 2025-07-10 109 BIT(INV_ICM45600_ACCEL_SCAN_Z))) {
1fb5c2bf7348d06 Remi Buisson 2025-07-10 110 /* enable accel sensor */
1fb5c2bf7348d06 Remi Buisson 2025-07-10 111 conf.mode = accel_st->power_mode;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 112 ret = inv_icm45600_set_accel_conf(st, &conf, &sleep);
1fb5c2bf7348d06 Remi Buisson 2025-07-10 113 if (ret)
1fb5c2bf7348d06 Remi Buisson 2025-07-10 114 return ret;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 115 fifo_en |= INV_ICM45600_SENSOR_ACCEL;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 116 }
1fb5c2bf7348d06 Remi Buisson 2025-07-10 117
1fb5c2bf7348d06 Remi Buisson 2025-07-10 118 /* Update data FIFO write. */
1fb5c2bf7348d06 Remi Buisson 2025-07-10 119 ret = inv_icm45600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
1fb5c2bf7348d06 Remi Buisson 2025-07-10 120 }
1fb5c2bf7348d06 Remi Buisson 2025-07-10 121
1fb5c2bf7348d06 Remi Buisson 2025-07-10 122 /* Sleep required time. */
1fb5c2bf7348d06 Remi Buisson 2025-07-10 123 if (sleep)
1fb5c2bf7348d06 Remi Buisson 2025-07-10 124 msleep(sleep);
1fb5c2bf7348d06 Remi Buisson 2025-07-10 125
1fb5c2bf7348d06 Remi Buisson 2025-07-10 126 return ret;
1fb5c2bf7348d06 Remi Buisson 2025-07-10 127 }
1fb5c2bf7348d06 Remi Buisson 2025-07-10 128
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists