linux-kernel - Re: [PATCH v2 1/1] mm/hmm: Move pmd_to_hmm_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHCie4QH9fUznga1@smile.fi.intel.com>
Date: Fri, 11 Jul 2025 08:34:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Alistair Popple <apopple@...dia.com>
Cc: Leon Romanovsky <leon@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Jérôme Glisse <jglisse@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v2 1/1] mm/hmm: Move pmd_to_hmm_pfn_flags() to the
 respective #ifdeffery

On Fri, Jul 11, 2025 at 09:35:49AM +1000, Alistair Popple wrote:
> Shouldn't the Fixes tag be for the commit that introduced the #ifdeffery in the
> first place? Ie: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX
> backed filesystem")

Looks indeed better, I was lost in the maze of the history of mm/hmm.c changes.

Fixes: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX backed filesystem")

The problem is that backporting to that, if needed, requires a bit of adaptation.
Nevertheless, I added it above, and we actually can have two Fixes tags to make
backporting easier for those (we don't have LTS kernels older that the second
commit anyway),

Andrew, can you add the above tag as well?

> As far as I can tell that is what would have introduced the warning. Other than
> that it looks good though so feel free to add:
> 
> Reviewed-by: Alistair Popple <apopple@...dia.com>

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko