linux-kernel - Re: [PATCH v7 10/12] nvmem: s32g2_siul2: add NVMEM driver for SoC information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9d004ea4-0bb2-4a21-8501-82ecf3482c3e@app.fastmail.com>
Date: Fri, 11 Jul 2025 07:37:01 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andrei Stefanescu" <andrei.stefanescu@....nxp.com>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Rob Herring" <robh@...nel.org>,
 krzk+dt@...nel.org, "Conor Dooley" <conor+dt@...nel.org>,
 "Chester Lin" <chester62515@...il.com>,
 "Matthias Brugger" <mbrugger@...e.com>,
 "Ghennadi Procopciuc" <Ghennadi.Procopciuc@....com>,
 "Larisa Grigore" <larisa.grigore@....com>, "Lee Jones" <lee@...nel.org>,
 "Shawn Guo" <shawnguo@...nel.org>, "Sascha Hauer" <s.hauer@...gutronix.de>,
 "Fabio Estevam" <festevam@...il.com>, aisheng.dong@....com,
 "Jacky Bai" <ping.bai@....com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 "Srinivas Kandagatla" <srini@...nel.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, "NXP S32 Linux Team" <s32@....com>,
 "Christophe Lizzi" <clizzi@...hat.com>, "Alberto Ruiz" <aruizrui@...hat.com>,
 "Enric Balletbo" <eballetb@...hat.com>, echanude@...hat.com,
 "Pengutronix Kernel Team" <kernel@...gutronix.de>, imx@...ts.linux.dev,
 "Vincent Guittot" <vincent.guittot@...aro.org>
Subject: Re: [PATCH v7 10/12] nvmem: s32g2_siul2: add NVMEM driver for SoC information

On Thu, Jul 10, 2025, at 16:20, Andrei Stefanescu wrote:
> The SIUL2 hardware module has registers which expose information about
> the given SoC (version, SRAM size, presence of some hw modules).
>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....nxp.com>

This does not look like an nvmem at all, it appears that you
are creating an alternative to the soc_device infrastructure
based on a binary interface tunneled through the nvmem subsystem.

Why not just make this a soc_device and have drivers use
soc_device_match() if they need to know what chip they are
running on?

    Arnd