linux-kernel - Re: [PATCH v2 2/2] phy: dw-dphy-rx: Add dt bindings for Synopsys MIPI D-PHY RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a4f27e3-49e7-4499-acad-c33d5cfec7a8@kernel.org>
Date: Fri, 11 Jul 2025 09:09:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Poduval, Karthik" <kpoduval@...126.com>
Cc: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "vkoul@...nel.org" <vkoul@...nel.org>, "Xiong, Jason" <jyxiong@...zon.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "Anish Kumar, FNU" <anishkmr@...zon.com>,
 "miguel.lopes@...opsys.com" <miguel.lopes@...opsys.com>,
 "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
 "kishon@...nel.org" <kishon@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>
Subject: Re: [PATCH v2 2/2] phy: dw-dphy-rx: Add dt bindings for Synopsys MIPI
 D-PHY RX

On 10/07/2025 23:24, Poduval, Karthik wrote:
>>> +maintainers:
>>> +  - Karthik Poduval <kpoduval@...126.com>
>>> +  - Jason Xiong <jyxiong@...zon.com>
>>> +  - Miguel Lopes <miguel.lopes@...opsys.com
>>> +
>>> +description: |
>>> +  These are the bindings for Synopsys Designware MIPI DPHY RX phy
>>> driver.
>>> +  Currently only supported phy version is v1.2.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: snps,dw-dphy-1p2
>>
>> You should rather use SoC compatibles.
> If similar Synopsys D-PHY is used in multiple SoCs with slight
> variations, should each SoC have its own D-PHY driver or is it better

Your incorrect subject probably mislead you, but this is not a driver
patch. These are DT bindings.

SoC specific compatibles are almost always preferred.

> to have a common one that works for all SoCs like arm,smmu-v3 or like
> the EEPROM driver below ? 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/misc/eeprom/eeprom_93xx46.c?h=v6.16-rc5#n391
> where driver specific driver_data could support multiple versions or
> SoC variations. 
> Our team thought of the common driver approach however looking for
> general guidance from PHY subsystem maintainers and contributors.

We don't discuss here driver.

Best regards,
Krzysztof