linux-kernel - Re: [PATCH v2 03/11] dt-bindings: arm: stm32: Modify STM32MP15x Phytec board items types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <576c1a468539b89f99c0fb33b7b7dbf9b27fa1cb.camel@phytec.fr>
Date: Fri, 11 Jul 2025 07:25:00 +0000
From: Christophe Parant <C.Parant@...tec.fr>
To: "robh@...nel.org" <robh@...nel.org>
CC: "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "upstream@...ts.phytec.de"
	<upstream@...ts.phytec.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "mcoquelin.stm32@...il.com"
	<mcoquelin.stm32@...il.com>
Subject: Re: [PATCH v2 03/11] dt-bindings: arm: stm32: Modify STM32MP15x
 Phytec board items types

Hello Rob,

Le jeudi 10 juillet 2025 à 17:25 -0500, Rob Herring a écrit :
> On Wed, Jul 09, 2025 at 05:10:03PM +0200, Christophe Parant wrote:
> > As Phytec manages different SoM configurations with different
> > STM32MP15
> > SoC versions, modify the phyBOARD and SoM compatible items to
> > "enum"
> > instead of "const".
> > The description concerns PHYTEC SoM equipped with STM32MP157
> > ("st,stm32mp157" is "const").
> > Also add comments in front of the enum items to be able to identify
> > the
> > compatible string with the phyBOARD/phyCORE names.
> 
> I don't understand the point of this patch.
> 
Thank your for your feedback.

> > Signed-off-by: Christophe Parant <c.parant@...tec.fr>
> > ---
> >  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 +++++--
> > -
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > index 408532504a24..fbd3d364c1f7 100644
> > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> > @@ -182,10 +182,12 @@ properties:
> >            - const: seeed,stm32mp157c-odyssey-som
> >            - const: st,stm32mp157
> >  
> > -      - description: Phytec STM32MP1 SoM based Boards
> > +      - description: Phytec STM32MP157 SoM based Boards
> >          items:
> > -          - const: phytec,phycore-stm32mp1-3
> > -          - const: phytec,phycore-stm32mp157c-som
> > +          - enum:
> > +              - phytec,phycore-stm32mp1-3 # phyBOARD-Sargas with
> > phyCORE-STM32MP157C SoM
> > +          - enum:
> > +              - phytec,phycore-stm32mp157c-som # phyCORE-
> > STM32MP157C SoM
> 
> Are you going to add more entries to the enums? Wouldn't those be a 
> different SoC and a whole other 'items' list because it wouldn't be
> the 
> 157 SoC?
> 
Yes, here we would also like to add our "phycore-stm32mp1-4" which is
equipped with the "F" version of stm32mp157: "stm32mp157f" (which is
another board device tree).
But didn't want to add it now in this patch series.
We also have "phycore-stm32mp1-6" which is equipped with "stm32mp153a".
The idea was to keep this Description section for the "st,stm32mp157"
(const items) and would need another section for the "st,stm32mp13a".

Best Regards,
Christophe
> >            - const: st,stm32mp157
> >  
> >        - description: Ultratronik STM32MP1 SBC based Boards
> > -- 
> > 2.34.1
> >