linux-kernel - Re: [PATCH v16 1/5] dt-bindings: mmc: sdhci-pxa: restrict pinctrl to pxav1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711-hypnotic-aloof-nuthatch-f3761c@krzk-bin>
Date: Fri, 11 Jul 2025 09:31:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Duje Mihanović <duje@...emihanovic.xyz>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Lubomir Rintel <lkundrak@...sk>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
	Gregory Clement <gregory.clement@...tlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, 
	Kees Cook <kees@...nel.org>, Tony Luck <tony.luck@...el.com>, 
	"Guilherme G. Piccoli" <gpiccoli@...lia.com>, Ulf Hansson <ulf.hansson@...aro.org>, 
	David Wronek <david@...nlining.org>, Karel Balej <balejk@...fyz.cz>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-hardening@...r.kernel.org, phone-devel@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht, soc@...ts.linux.dev, linux-mmc@...r.kernel.org
Subject: Re: [PATCH v16 1/5] dt-bindings: mmc: sdhci-pxa: restrict pinctrl to
 pxav1

On Wed, Jul 09, 2025 at 07:33:01PM +0200, Duje Mihanović wrote:
> On Wednesday, 9 July 2025 09:32:06 Central European Summer Time Krzysztof 
> Kozlowski wrote:
> > On Tue, Jul 08, 2025 at 07:09:46PM +0200, Duje Mihanović wrote:
> > > The current pinctrl properties apply only to the pxav1 controller.
> > 
> > Why they are not applicable for pxav3?
> 
> state_cmd_gpio is used for working around a PXA168 SDIO erratum. That SoC uses 
> the pxav1 controller and no such erratum exists on any of the other PXA SoCs.

I really don't get whether you are describing problem with schema or
actual state of hardware, especially considering this patch. You use
here present tense, which usually means state before this patch, but
your patch is changing this. IOW, if current pinctrl properties apply
only to pxav1, this matches what you said about hardware, so job is
done. No need for this patch.

> 
> > > Adding one default pinctrl node to a pxav3 controller therefore causes
> > > a schema warning.
> > > 
> > > Check the existing properties only on pxav1. pxav2 and pxav3 may add
> > > their own set of pinctrl properties if and when needed.
> > 
> > This should be rather made complete here, because properties should be
> > defined in top-level, not in allOf: block. Strictly speaking pinctrl-xxx
> > are defined in core schema, but still the binding should follow same
> > rule - define them in top.
> 
> Would it then be acceptable to declare the pinctrl properties in the top level 
> and define each controller's respective description: and items: in the allOf: 
> block?

just min/maxItems should be enough in each allOf:if:then: sections.

Best regards,
Krzysztof