linux-kernel - Re: [PATCH v2 06/13] media: platform: mediatek: add isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d02055f2e5ebb8df072eef398af85cdd99b4a6ef.camel@mediatek.com>
Date: Fri, 11 Jul 2025 08:56:50 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Shangyao Lin (林上堯)
	<Shangyao.Lin@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 06/13] media: platform: mediatek: add isp_7x state ctrl

On Mon, 2025-07-07 at 09:31 +0800, shangyao lin wrote:
> From: "shangyao.lin" <shangyao.lin@...iatek.com>
> 
> Introduce state management and debugging mechanisms for the MediaTek ISP7.x
> camsys platform. State management establishes control over ISP operations and
> events, defining distinct states for request handling, sensor control, and
> frame synchronization, ensuring proper event processing. The debugging
> mechanism ensures stable operation and timely data collection during anomalies.
> 
> ---
> 
> Changes in v2:
> - Removed mtk_cam-debug.c and mtk_cam-debug.h, along with related code
> - Various fixes per review comments
> 
> Signed-off-by: shangyao.lin <shangyao.lin@...iatek.com>
> ---

[snip]

> +static bool mtk_cam_request_drained(struct mtk_camsys_sensor_ctrl *sensor_ctrl)
> +{
> +	struct mtk_cam_ctx *ctx = sensor_ctrl->ctx;

You use struct mtk_cam_ctx in this patch, but it's defined in patch [8/13].
You should define it first and then use it.
But here you use struct mtk_cam_ctx which is defined in later patch.
To prevent this, you could apply one patch and build code once.
For example,

After apply patch [5/13], build code.
After apply patch [6/13], build code.
After apply patch [7/13], build code.
...

The step would help you to prevent using symbol which has not defined.
In addition, this patch just add .c file but not add it in Makefile.
When you add .c, also add it in Makefile so you could check it could be built successfully.

Regards,
CK

> +	int sensor_seq_no_next =
> +		atomic_read(&sensor_ctrl->sensor_request_seq_no) + 1;
> +	int res = 0;
> +
> +	if (sensor_seq_no_next <= atomic_read(&ctx->enqueued_frame_seq_no))
> +		res = 1;
> +	/* Send V4L2_EVENT_REQUEST_DRAINED event */
> +	if (res == 0) {
> +		mtk_cam_event_request_drained(ctx->pipe);
> +		dev_dbg(ctx->cam->dev, "request_drained:(%d)\n",
> +			sensor_seq_no_next);
> +	}
> +	return (res == 0);
> +}
> +