linux-kernel - Re: [PATCH v2] can: m_can: apply rate-limiting to lost msg in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250711-sloppy-righteous-falcon-db09cc-mkl@pengutronix.de>
Date: Fri, 11 Jul 2025 12:04:19 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, Fengguang Wu <fengguang.wu@...el.com>, 
	Varka Bhadram <varkabhadram@...il.com>, Dong Aisheng <b29396@...escale.com>, linux-can@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] can: m_can: apply rate-limiting to lost msg in rx

On 11.07.2025 09:58:53, Sean Nyekjaer wrote:
> > What about replacing the netdev_err() by netdev_dbg()?
> > 
> > --- a/drivers/net/can/m_can/m_can.c
> > +++ b/drivers/net/can/m_can/m_can.c
> > @@ -665,7 +665,7 @@ static int m_can_handle_lost_msg(struct net_device *dev)
> >         struct can_frame *frame;
> >         u32 timestamp = 0;
> > 
> > -       netdev_err(dev, "msg lost in rxf0\n");
> > +       netdev_dbg(dev, "msg lost in rxf0\n");
> > 
> >         stats->rx_errors++;
> >         stats->rx_over_errors++;
> > 
> 
> Yeah that will do. V3 or?

Yes, please.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)