[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <qnaduioo2qqt25k5zv5dpwne7s4a6zph6ma2dsnospex7fnrar@drnpfuel7ipe>
Date: Fri, 11 Jul 2025 10:04:40 +0000
From: Sean Nyekjaer <sean@...nix.com>
To: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Sebastian Reichel <sre@...nel.org>, Frank Li <Frank.li@....com>, imx@...ts.linux.dev, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, linux-pm@...r.kernel.org, Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abelvesa@...ux.com>, Robin Gong <b38343@...escale.com>, Robin Gong <yibin.gong@....com>, Enric Balletbo i Serra <eballetbo@...il.com>
Subject: Re: [PATCH v8 3/6] regulator: pf1550: add support for regulator
On Mon, Jul 07, 2025 at 05:37:22PM +0100, Samuel Kayode wrote:
> Add regulator support for the pf1550 PMIC.
>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Reviewed-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
> ---
[...]
> +
> +struct pf1550_desc {
> + struct regulator_desc desc;
> + unsigned char stby_reg;
> + unsigned char stby_mask;
> +};
> +
I would suggest doing support for the stby voltages. We are using them
to lower consumption in suspend.
>From the devicetree we configure:
regulator-suspend-min-microvolt, regulator-suspend-max-microvolt,
regulator-off-in-suspend and/or regulator-on-in-suspend
/Sean
Powered by blists - more mailing lists