linux-kernel - Re: [PATCH 2/2] nvmem: imx: Swap only the first 6 bytes of the MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2192511.9o76ZdvQCi@n9w6sw14>
Date: Fri, 11 Jul 2025 14:11:57 +0200
From: Christian Eggers <ceggers@...i.de>
To: Steffen Bätz <steffen@...osonix.de>, Fabio Estevam
	<festevam@...il.com>
CC: Srinivas Kandagatla <srini@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, Dmitry Baryshkov <lumag@...nel.org>,
	Rafał Miłecki <rafal@...ecki.pl>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sasha Levin <sashal@...nel.org>, <imx@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] nvmem: imx: Swap only the first 6 bytes of the MAC address

Hi Fabio, hi Steffen,

On Friday, 11 July 2025, 14:05:16 CEST, Fabio Estevam wrote:
> Hi Christian,
> 
> On Fri, Jul 11, 2025 at 9:01 AM Christian Eggers <ceggers@...i.de> wrote:
> >
> > Since commit 55d4980ce55b ("nvmem: core: support specifying both: cell
> > raw data & post read lengths"), the aligned length (e.g. '8' instead of
> > '6') is passed to the read_post_process callback. This causes that the 2
> > bytes following the MAC address in the ocotp are swapped to the
> > beginning of the address. As a result, an invalid MAC address is
> > returned and to make it even worse, this address can be equal on boards
> > with the same OUI vendor prefix.
> >
> > Fixes: 55d4980ce55b ("nvmem: core: support specifying both: cell raw data & post read lengths")
> > Signed-off-by: Christian Eggers <ceggers@...i.de>
> > Cc: stable@...r.kernel.org
> > ---
> > Tested on i.MX6ULL, but I assume that this is also required for.
> > imx-ocotp-ele.c (i.MX93).
> 
> Steffen has recently sent a similar fix:
> 
> https://lore.kernel.org/linux-arm-kernel/20250708101206.70793-1-steffen@innosonix.de/
> 
> Does this work for you?
your patch does obviously the same as mine. So the answer is 'yes'

regards,
Christian