linux-kernel - Re: [PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <723330733.1712525.1752237188810.JavaMail.zimbra@couthit.local>
Date: Fri, 11 Jul 2025 18:03:08 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: kuba <kuba@...nel.org>
Cc: parvathi <parvathi@...thit.com>, danishanwar <danishanwar@...com>, 
	rogerq <rogerq@...nel.org>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	pabeni <pabeni@...hat.com>, robh <robh@...nel.org>, 
	krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>, 
	ssantosh <ssantosh@...nel.org>, 
	richardcochran <richardcochran@...il.com>, 
	s hauer <s.hauer@...gutronix.de>, m-karicheri2 <m-karicheri2@...com>, 
	glaroque <glaroque@...libre.com>, afd <afd@...com>, 
	saikrishnag <saikrishnag@...vell.com>, m-malladi <m-malladi@...com>, 
	jacob e keller <jacob.e.keller@...el.com>, 
	diogo ivo <diogo.ivo@...mens.com>, 
	javier carrasco cruz <javier.carrasco.cruz@...il.com>, 
	horms <horms@...nel.org>, s-anna <s-anna@...com>, 
	basharath <basharath@...thit.com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>, 
	mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v10 04/11] net: ti: prueth: Adds link
 detection, RX and TX support.


Hi,

> On Wed,  2 Jul 2025 20:47:49 +0530 Parvathi Pudi wrote:
>> +			if (emac->port_id) {
>> +				regmap_update_bits
>> +					(prueth->mii_rt,
>> +					 PRUSS_MII_RT_TXCFG1,
>> +					 PRUSS_MII_RT_TXCFG_TX_CLK_DELAY_MASK,
>> +					 delay);
> 
> Instead of breaking the lines up like this you should factor the code
> out or find some other way to reduce the indentation.
> 

Sure, we will address this in the next version.

>> +	qid = icssm_prueth_get_tx_queue_id(emac->prueth, skb);
>> +	ret = icssm_prueth_tx_enqueue(emac, skb, qid);
>> +	if (ret) {
>> +		if (ret != -ENOBUFS && netif_msg_tx_err(emac) &&
>> +		    net_ratelimit())
>> +			netdev_err(ndev, "packet queue failed: %d\n", ret);
>> +		goto fail_tx;
>> +	}
> 
>> +	if (ret == -ENOBUFS) {
>> +		ret = NETDEV_TX_BUSY;
> 
> 
> Something needs to stop the queue, right? Otherwise the stack will
> send the frame right back to the driver.
> 

Yes, we will notify upper layer with “netif_tx_stop_queue()” when returning
“NETDEV_TX_BUSY” to not push again immediately.

>> +static inline void icssm_emac_finish_napi(struct prueth_emac *emac,
>> +					  struct napi_struct *napi,
>> +					  int irq)
>> +{
>> +	napi_complete(napi);
>> +	enable_irq(irq);
> 
> This helper has a single caller, just put the two lines of code directly
> there. And use napi_complete_done(), please.

We will address this in the next version.

Thanks and Regards,
Parvathi.