linux-kernel - [PATCH 1/1] PCA9541: Increase I2C bus arbitration timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250711124503.3390451-2-manikanta.guntupalli@amd.com>
Date: Fri, 11 Jul 2025 18:15:03 +0530
From: Manikanta Guntupalli <manikanta.guntupalli@....com>
To: <git@....com>, <michal.simek@....com>, <peda@...ntia.se>,
	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <radhey.shyam.pandey@....com>, <srinivas.goud@....com>,
	<shubhrajyoti.datta@....com>, <manikantaguntupalli09@...il.com>, "Jonathan
 Stroud" <jonathan.stroud@....com>, Manikanta Guntupalli
	<manikanta.guntupalli@....com>
Subject: [PATCH 1/1] PCA9541: Increase I2C bus arbitration timeout

From: Jonathan Stroud <jonathan.stroud@....com>

When u-boot has the bus acquired on the other host, it can hold the bus
for much longer than 125ms.  Forcefully stealing the bus will result in
u-boot hanging.  Increase arbitration timeout to 1 second to avoid this
condition.

Arbitration timeout and forcefully taking the bus should only be
happening in a failure condition when the other host is dead.  Therefor
increasing this timeout to a large value should not impact normal
operation.

Signed-off-by: Jonathan Stroud <jonathan.stroud@....com>
Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>
---
 drivers/i2c/muxes/i2c-mux-pca9541.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 8663c8a7c269..e602c4a294d3 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -64,8 +64,8 @@
 #define busoff(x)	(!((x) & BUSON) || ((x) & BUSON) == BUSON)
 
 /* arbitration timeouts, in jiffies */
-#define ARB_TIMEOUT	(HZ / 8)	/* 125 ms until forcing bus ownership */
-#define ARB2_TIMEOUT	(HZ / 4)	/* 250 ms until acquisition failure */
+#define ARB_TIMEOUT	(HZ)		/* 1 s until forcing bus ownership */
+#define ARB2_TIMEOUT	(2 * HZ)	/* 2 s until acquisition failure */
 
 /* arbitration retry delays, in us */
 #define SELECT_DELAY_SHORT	50
@@ -229,6 +229,7 @@ static int pca9541_arbitrate(struct i2c_client *client)
 		 */
 		data->select_timeout = SELECT_DELAY_LONG;
 		if (time_is_before_eq_jiffies(data->arb_timeout)) {
+			dev_info(&client->dev, "I2C Bus Arbiter timeout, forcing take bus\n");
 			/* Time is up, take the bus and reset it. */
 			pca9541_reg_write(client,
 					  PCA9541_CONTROL,
@@ -267,6 +268,7 @@ static int pca9541_select_chan(struct i2c_mux_core *muxc, u32 chan)
 		else
 			msleep(data->select_timeout / 1000);
 	} while (time_is_after_eq_jiffies(timeout));
+	dev_info(&client->dev, "Timeout acquiring I2C bus\n");
 
 	return -ETIMEDOUT;
 }
-- 
2.34.1