linux-kernel - Re: [PATCH 1/2] entry: Add arch_in_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250711132633.GF905792@noisy.programming.kicks-ass.net>
Date: Fri, 11 Jul 2025 15:26:33 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Andrew Donnellan <ajd@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	kvm@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Janosch Frank <frankja@...ux.ibm.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Claudio Imbrenda <imbrenda@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] entry: Add arch_in_rcu_eqs()

On Tue, Jul 08, 2025 at 07:27:41PM +1000, Andrew Donnellan wrote:
> From: Mark Rutland <mark.rutland@....com>
> 
> All architectures have an interruptible RCU extended quiescent state
> (EQS) as part of their idle sequences, where interrupts can occur
> without RCU watching. Entry code must account for this and wake RCU as
> necessary; the common entry code deals with this in irqentry_enter() by
> treating any interrupt from an idle thread as potentially having
> occurred within an EQS and waking RCU for the duration of the interrupt
> via rcu_irq_enter() .. rcu_irq_exit().
> 
> Some architectures may have other interruptible EQSs which require
> similar treatment. For example, on s390 it is necessary to enable
> interrupts around guest entry in the middle of a period where core KVM
> code has entered an EQS.
> 
> So that architectures can wake RCU in these cases, this patch adds a
> new arch_in_rcu_eqs() hook to the common entry code which is checked in
> addition to the existing is_idle_thread() check, with RCU woken if
> either returns true. A default implementation is provided which always
> returns false, which suffices for most architectures.
> 
> As no architectures currently implement arch_in_rcu_eqs(), there should
> be no functional change as a result of this patch alone. A subsequent
> patch will add an s390 implementation to fix a latent bug with missing
> RCU wakeups.
> 
> [ajd@...ux.ibm.com: rebase, fix commit message]
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Paul E. McKenney <paulmck@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Janosch Frank <frankja@...ux.ibm.com>
> Reviewed-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd@...ux.ibm.com>

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

> ---
>  include/linux/entry-common.h | 16 ++++++++++++++++
>  kernel/entry/common.c        |  3 ++-
>  2 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/entry-common.h b/include/linux/entry-common.h
> index f94f3fdf15fc..3bf99cbad8a3 100644
> --- a/include/linux/entry-common.h
> +++ b/include/linux/entry-common.h
> @@ -86,6 +86,22 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs);
>  static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs) {}
>  #endif
>  
> +/**
> + * arch_in_rcu_eqs - Architecture specific check for RCU extended quiescent
> + * states.
> + *
> + * Returns: true if the CPU is potentially in an RCU EQS, false otherwise.
> + *
> + * Architectures only need to define this if threads other than the idle thread
> + * may have an interruptible EQS. This does not need to handle idle threads. It
> + * is safe to over-estimate at the cost of redundant RCU management work.
> + *
> + * Invoked from irqentry_enter()
> + */
> +#ifndef arch_in_rcu_eqs
> +static __always_inline bool arch_in_rcu_eqs(void) { return false; }
> +#endif
> +
>  /**
>   * enter_from_user_mode - Establish state when coming from user mode
>   *
> diff --git a/kernel/entry/common.c b/kernel/entry/common.c
> index a8dd1f27417c..eb52d38e8099 100644
> --- a/kernel/entry/common.c
> +++ b/kernel/entry/common.c
> @@ -220,7 +220,8 @@ noinstr irqentry_state_t irqentry_enter(struct pt_regs *regs)
>  	 * TINY_RCU does not support EQS, so let the compiler eliminate
>  	 * this part when enabled.
>  	 */
> -	if (!IS_ENABLED(CONFIG_TINY_RCU) && is_idle_task(current)) {
> +	if (!IS_ENABLED(CONFIG_TINY_RCU) &&
> +	    (is_idle_task(current) || arch_in_rcu_eqs())) {
>  		/*
>  		 * If RCU is not watching then the same careful
>  		 * sequence vs. lockdep and tracing is required
> -- 
> 2.50.0
>