linux-kernel - Re: linux-next: Tree for Jul 11 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h1CX+aTu7dFy6vB-9LM6t5J4rt7Su3qVnq1xx-BFAm=Q@mail.gmail.com>
Date: Sat, 12 Jul 2025 10:11:27 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>, Mario Limonciello <mario.limonciello@....com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux DRI Development <dri-devel@...ts.freedesktop.org>, Samuel Zhang <guoqing.zhang@....com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, amd-gfx@...ts.freedesktop.org
Subject: Re: linux-next: Tree for Jul 11 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

On Fri, Jul 11, 2025 at 11:25 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 7/11/25 2:10 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20250710:
> >
>
> on x86_64, when
> # CONFIG_SUSPEND is not set
> # CONFIG_HIBERNATION is not set
> # CONFIG_PM is not set
>
> ERROR: modpost: "pm_hibernate_is_recovering" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> caused by commit
> 530694f54dd5e ("drm/amdgpu: do not resume device in thaw for normal hibernation")
>
> Rafael, is a stub appropriate for this case?

pm_hibernate_is_recovering() is not supposed to be called by code that
does not depend on CONFIG_HIBERNATE_CALLBACKS, but a stub returning
false would work for this.

Mario, it would be good to fix this up in your tree.  Also, it would
be good to expose stuff to 0-day build testing before letting it go
into linux-next.  I use the bleeding-edge branch for this purpose.