linux-kernel - Re: [PATCH net-next 02/12] ptp: netc: add NETC Timer PTP driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507121901.cz1bRBUf-lkp@intel.com>
Date: Sat, 12 Jul 2025 19:53:27 +0800
From: kernel test robot <lkp@...el.com>
To: Wei Fang <wei.fang@....com>, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, richardcochran@...il.com,
	claudiu.manoil@....com, vladimir.oltean@....com,
	xiaoning.wang@....com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, fushi.peng@....com,
	devicetree@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH net-next 02/12] ptp: netc: add NETC Timer PTP driver
 support

Hi Wei,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Wei-Fang/dt-bindings-ptp-add-bindings-for-NETC-Timer/20250711-152311
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250711065748.250159-3-wei.fang%40nxp.com
patch subject: [PATCH net-next 02/12] ptp: netc: add NETC Timer PTP driver support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250712/202507121901.cz1bRBUf-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250712/202507121901.cz1bRBUf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507121901.cz1bRBUf-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/ptp/ptp_netc.c: In function 'netc_timer_adjust_period':
>> drivers/ptp/ptp_netc.c:161:20: error: implicit declaration of function 'u32_replace_bits' [-Wimplicit-function-declaration]
     161 |         tmr_ctrl = u32_replace_bits(old_tmr_ctrl, integral_period,
         |                    ^~~~~~~~~~~~~~~~


vim +/u32_replace_bits +161 drivers/ptp/ptp_netc.c

   150	
   151	static void netc_timer_adjust_period(struct netc_timer *priv, u64 period)
   152	{
   153		u32 fractional_period = lower_32_bits(period);
   154		u32 integral_period = upper_32_bits(period);
   155		u32 tmr_ctrl, old_tmr_ctrl;
   156		unsigned long flags;
   157	
   158		spin_lock_irqsave(&priv->lock, flags);
   159	
   160		old_tmr_ctrl = netc_timer_rd(priv, NETC_TMR_CTRL);
 > 161		tmr_ctrl = u32_replace_bits(old_tmr_ctrl, integral_period,
   162					    TMR_CTRL_TCLK_PERIOD);
   163		if (tmr_ctrl != old_tmr_ctrl)
   164			netc_timer_wr(priv, NETC_TMR_CTRL, tmr_ctrl);
   165	
   166		netc_timer_wr(priv, NETC_TMR_ADD, fractional_period);
   167	
   168		spin_unlock_irqrestore(&priv->lock, flags);
   169	}
   170	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki