linux-kernel - Re: [PATCH net-next v2 1/1] net: selftests: add PHY-loopback test for bad TCP checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250712122511.GY721198@horms.kernel.org>
Date: Sat, 12 Jul 2025 13:25:11 +0100
From: Simon Horman <horms@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v2 1/1] net: selftests: add PHY-loopback test
 for bad TCP checksums

On Fri, Jul 11, 2025 at 09:24:49AM +0200, Oleksij Rempel wrote:
> Detect NICs and drivers that either drop frames with a corrupted TCP
> checksum or, worse, pass them up as valid.  The test flips one bit in
> the checksum, transmits the packet in internal loopback, and fails when
> the driver reports CHECKSUM_UNNECESSARY.
> 
> Discussed at:
> https://lore.kernel.org/all/20250625132117.1b3264e8@kernel.org/
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> changes v2:
> - Replaced manual calculation of TCP checksum with standard kernel helper
>   skb_checksum_help().
> - add test documentation

Reviewed-by: Simon Horman <horms@...nel.org>