linux-kernel - [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250712133609.331904-1-khaledelnaggarlinux@gmail.com>
Date: Sat, 12 Jul 2025 16:36:07 +0300
From: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
To: mkl@...gutronix.de,
	mailhol.vincent@...adoo.fr
Cc: Khaled Elnaggar <khaledelnaggarlinux@...il.com>,
	linux-kernel-mentees@...ts.linux.dev,
	shuah@...nel.org,
	linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo_show()

As recommended in Documentation/filesystems/sysfs.rst, show() callbacks
should use sysfs_emit() or sysfs_emit_at() to format values returned to
userspace. Replace scnprintf() with sysfs_emit() in fwinfo_show().

Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
---
 drivers/net/can/janz-ican3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index 60c7b83b4539..bfa5cbe88017 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1867,7 +1867,7 @@ static ssize_t fwinfo_show(struct device *dev,
 {
 	struct ican3_dev *mod = netdev_priv(to_net_dev(dev));
 
-	return scnprintf(buf, PAGE_SIZE, "%s\n", mod->fwinfo);
+	return sysfs_emit(buf, "%s\n", mod->fwinfo);
 }
 
 static DEVICE_ATTR_RW(termination);
-- 
2.47.2