linux-kernel - Re: [PATCH] scsi: hisi_sas: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071244-widely-strangely-b24c@gregkh>
Date: Sat, 12 Jul 2025 16:43:09 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
Cc: liyihang9@...wei.com, James.Bottomley@...senpartnership.com,
	martin.petersen@...cle.com, linux-kernel-mentees@...ts.linux.dev,
	shuah@...nel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: use sysfs_emit() in v3 hw show()
 functions

On Sat, Jul 12, 2025 at 05:28:03PM +0300, Khaled Elnaggar wrote:
> Replace scnprintf() with sysfs_emit() in several sysfs show()
> callbacks in hisi_sas_v3_hw.c. This is recommended in
> Documentation/filesystems/sysfs.rst for formatting values returned to
> userspace.

For new users, yes, but what's wrong with these existing calls?  They
still work properly, so why change them?

thanks,

greg k-h