linux-kernel - Re: [PATCH v2 3/4] memory: renesas-rpc-if: Add RZ/A1 and RZ/A2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5977e5d9-c369-47f4-a35f-bc5c9488d5bc@kernel.org>
Date: Sat, 12 Jul 2025 18:48:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Magnus Damm <damm@...nsource.se>, linux-renesas-soc@...r.kernel.org
Cc: robh@...nel.org, geert+renesas@...der.be, devicetree@...r.kernel.org,
 conor+dt@...nel.org, linux-kernel@...r.kernel.org,
 wsa+renesas@...g-engineering.com, sergei.shtylyov@...il.com,
 p.zabel@...gutronix.de
Subject: Re: [PATCH v2 3/4] memory: renesas-rpc-if: Add RZ/A1 and RZ/A2
 support

On 12/07/2025 15:39, Magnus Damm wrote:
> From: Magnus Damm <damm@...nsource.se>
> 
> Add RZ/A1 and RZ/A2 compat strings to the rpc-if driver. Also make the
> reset controller optional. This is because RZ/A1 does not have any reset
> bits assigned to the device so there is no reset controller available.

That's different ABI and if you tested bindings, you would see warnings.
My previous instruction was really important so I am disappointed that
you replied that you are not going to test bindings or your DTS patches.

Fix the bindings.

> +
>  static const struct of_device_id rpcif_of_match[] = {
> +	{ .compatible = "renesas,r7s72100-rpc-if", .data = &rpcif_info_rz_a },
> +	{ .compatible = "renesas,r7s9210-rpc-if", .data = &rpcif_info_rz_a },

So devices are compatible. Express it with proper fallbacks and don't
create redundant entries.

Or explain in the binding WHY they are not compatible.

Best regards,
Krzysztof