linux-kernel - Re: [RFC PATCH v8 15/35] x86/apic: Unionize apic regs for 32bit/64bit access w/o type casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8483f20-b8ee-4369-ad00-0154ff05d10c@amd.com>
Date: Sat, 12 Jul 2025 22:38:08 +0530
From: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: Sean Christopherson <seanjc@...gle.com>, linux-kernel@...r.kernel.org,
 tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
 Thomas.Lendacky@....com, nikunj@....com, Santosh.Shukla@....com,
 Vasant.Hegde@....com, Suravee.Suthikulpanit@....com, David.Kaplan@....com,
 x86@...nel.org, hpa@...or.com, peterz@...radead.org, pbonzini@...hat.com,
 kvm@...r.kernel.org, kirill.shutemov@...ux.intel.com, huibo.wang@....com,
 naveen.rao@....com, kai.huang@...el.com
Subject: Re: [RFC PATCH v8 15/35] x86/apic: Unionize apic regs for 32bit/64bit
 access w/o type casting



On 7/12/2025 8:51 PM, Borislav Petkov wrote:
> On Thu, Jul 10, 2025 at 09:13:11AM +0530, Neeraj Upadhyay wrote:
>>     struct secure_apic_page {
>> 	u8 *regs[PAGE_SIZE];
>>     } __aligned(PAGE_SIZE);
>>
>>
>> to
>>
>>     struct secure_apic_page {
> 
> secure_apic_page or secure_aVic_page?
>

In v8, the struct was named "apic_page". Sean's suggested to use "secure_apic_page"
to avoid name conflicts with other apic code. APM calls it "guest APIC backing page" -
guest-owned page containing APIC state.
 
> I mean, what is a secure APIC?
> 

It was more to imply like secure APIC-page rather than Secure-APIC page. I will change
it to secure_avic_page or savic_apic_page, if one of these looks cleaner. Please suggest.


- Neeraj