| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202507120757.OQ27yP2N-lkp@intel.com>
Date: Sat, 12 Jul 2025 07:57:01 +0800
From: kernel test robot <lkp@...el.com>
To: Sudeep Holla <sudeep.holla@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Guenter Roeck <linux@...ck-us.net>
Subject: drivers/hwmon/xgene-hwmon.c:145:15: sparse: sparse: dereference of
noderef expression
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 40f92e79b0aabbf3575e371f9054657a421a3e79
commit: 80fcd1e7f5c7009fa1c64737df100cc304c19c1f hwmon: (xgene-hwmon) Simplify PCC shared memory region handling
date: 3 months ago
config: arm64-randconfig-r113-20250711 (https://download.01.org/0day-ci/archive/20250712/202507120757.OQ27yP2N-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
reproduce: (https://download.01.org/0day-ci/archive/20250712/202507120757.OQ27yP2N-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507120757.OQ27yP2N-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/hwmon/xgene-hwmon.c:116:15: sparse: sparse: cast to restricted __le16
drivers/hwmon/xgene-hwmon.c:119:9: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short volatile @@ got restricted __le16 [usertype] @@
drivers/hwmon/xgene-hwmon.c:119:9: sparse: expected unsigned short volatile
drivers/hwmon/xgene-hwmon.c:119:9: sparse: got restricted __le16 [usertype]
drivers/hwmon/xgene-hwmon.c:128:21: sparse: sparse: cast removes address space '__iomem' of expression
drivers/hwmon/xgene-hwmon.c:137:9: sparse: sparse: cast removes address space '__iomem' of expression
drivers/hwmon/xgene-hwmon.c:137:9: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int volatile @@ got restricted __le32 [usertype] @@
drivers/hwmon/xgene-hwmon.c:137:9: sparse: expected unsigned int volatile
drivers/hwmon/xgene-hwmon.c:137:9: sparse: got restricted __le32 [usertype]
drivers/hwmon/xgene-hwmon.c:141:9: sparse: sparse: cast removes address space '__iomem' of expression
drivers/hwmon/xgene-hwmon.c:141:9: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short volatile @@ got restricted __le16 [usertype] @@
drivers/hwmon/xgene-hwmon.c:141:9: sparse: expected unsigned short volatile
drivers/hwmon/xgene-hwmon.c:141:9: sparse: got restricted __le16 [usertype]
drivers/hwmon/xgene-hwmon.c:145:15: sparse: sparse: cast to restricted __le16
drivers/hwmon/xgene-hwmon.c:147:9: sparse: sparse: cast removes address space '__iomem' of expression
drivers/hwmon/xgene-hwmon.c:147:9: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short volatile @@ got restricted __le16 [usertype] @@
drivers/hwmon/xgene-hwmon.c:147:9: sparse: expected unsigned short volatile
drivers/hwmon/xgene-hwmon.c:147:9: sparse: got restricted __le16 [usertype]
drivers/hwmon/xgene-hwmon.c:151:17: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int volatile @@ got restricted __le32 [usertype] @@
drivers/hwmon/xgene-hwmon.c:151:17: sparse: expected unsigned int volatile
drivers/hwmon/xgene-hwmon.c:151:17: sparse: got restricted __le32 [usertype]
drivers/hwmon/xgene-hwmon.c:538:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *msg @@ got struct acpi_pcct_shared_memory [noderef] __iomem * @@
drivers/hwmon/xgene-hwmon.c:538:13: sparse: expected void *msg
drivers/hwmon/xgene-hwmon.c:538:13: sparse: got struct acpi_pcct_shared_memory [noderef] __iomem *
drivers/hwmon/xgene-hwmon.c:540:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned short [usertype] *addr @@ got unsigned short [noderef] __iomem * @@
drivers/hwmon/xgene-hwmon.c:540:38: sparse: expected unsigned short [usertype] *addr
drivers/hwmon/xgene-hwmon.c:540:38: sparse: got unsigned short [noderef] __iomem *
drivers/hwmon/xgene-hwmon.c:562:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned short [usertype] *addr @@ got unsigned short [noderef] __iomem * @@
drivers/hwmon/xgene-hwmon.c:562:45: sparse: expected unsigned short [usertype] *addr
drivers/hwmon/xgene-hwmon.c:562:45: sparse: got unsigned short [noderef] __iomem *
>> drivers/hwmon/xgene-hwmon.c:145:15: sparse: sparse: dereference of noderef expression
vim +145 drivers/hwmon/xgene-hwmon.c
ed42cfa881e1d8 hotran 2016-07-21 123
ed42cfa881e1d8 hotran 2016-07-21 124 static int xgene_hwmon_pcc_rd(struct xgene_hwmon_dev *ctx, u32 *msg)
ed42cfa881e1d8 hotran 2016-07-21 125 {
80fcd1e7f5c700 Sudeep Holla 2025-04-11 126 struct acpi_pcct_shared_memory __iomem *generic_comm_base =
80fcd1e7f5c700 Sudeep Holla 2025-04-11 127 ctx->pcc_chan->shmem;
c7cefce03e6912 Arnd Bergmann 2016-09-09 128 u32 *ptr = (void *)(generic_comm_base + 1);
ed42cfa881e1d8 hotran 2016-07-21 129 int rc, i;
ed42cfa881e1d8 hotran 2016-07-21 130 u16 val;
ed42cfa881e1d8 hotran 2016-07-21 131
ed42cfa881e1d8 hotran 2016-07-21 132 mutex_lock(&ctx->rd_mutex);
ed42cfa881e1d8 hotran 2016-07-21 133 init_completion(&ctx->rd_complete);
ed42cfa881e1d8 hotran 2016-07-21 134 ctx->resp_pending = true;
ed42cfa881e1d8 hotran 2016-07-21 135
ed42cfa881e1d8 hotran 2016-07-21 136 /* Write signature for subspace */
c7cefce03e6912 Arnd Bergmann 2016-09-09 137 WRITE_ONCE(generic_comm_base->signature,
2cf39b806be746 Sudeep Holla 2023-09-27 138 cpu_to_le32(PCC_SIGNATURE | ctx->mbox_idx));
ed42cfa881e1d8 hotran 2016-07-21 139
ed42cfa881e1d8 hotran 2016-07-21 140 /* Write to the shared command region */
c7cefce03e6912 Arnd Bergmann 2016-09-09 141 WRITE_ONCE(generic_comm_base->command,
2cf39b806be746 Sudeep Holla 2023-09-27 142 cpu_to_le16(MSG_TYPE(msg[0]) | PCC_CMD_GENERATE_DB_INTR));
ed42cfa881e1d8 hotran 2016-07-21 143
ed42cfa881e1d8 hotran 2016-07-21 144 /* Flip CMD COMPLETE bit */
c7cefce03e6912 Arnd Bergmann 2016-09-09 @145 val = le16_to_cpu(READ_ONCE(generic_comm_base->status));
2cf39b806be746 Sudeep Holla 2023-09-27 146 val &= ~PCC_STATUS_CMD_COMPLETE;
c7cefce03e6912 Arnd Bergmann 2016-09-09 147 WRITE_ONCE(generic_comm_base->status, cpu_to_le16(val));
ed42cfa881e1d8 hotran 2016-07-21 148
ed42cfa881e1d8 hotran 2016-07-21 149 /* Copy the message to the PCC comm space */
ed42cfa881e1d8 hotran 2016-07-21 150 for (i = 0; i < sizeof(struct slimpro_resp_msg) / 4; i++)
c7cefce03e6912 Arnd Bergmann 2016-09-09 151 WRITE_ONCE(ptr[i], cpu_to_le32(msg[i]));
ed42cfa881e1d8 hotran 2016-07-21 152
ed42cfa881e1d8 hotran 2016-07-21 153 /* Ring the doorbell */
ed42cfa881e1d8 hotran 2016-07-21 154 rc = mbox_send_message(ctx->mbox_chan, msg);
ed42cfa881e1d8 hotran 2016-07-21 155 if (rc < 0) {
ed42cfa881e1d8 hotran 2016-07-21 156 dev_err(ctx->dev, "Mailbox send error %d\n", rc);
ed42cfa881e1d8 hotran 2016-07-21 157 goto err;
ed42cfa881e1d8 hotran 2016-07-21 158 }
ed42cfa881e1d8 hotran 2016-07-21 159 if (!wait_for_completion_timeout(&ctx->rd_complete,
ed42cfa881e1d8 hotran 2016-07-21 160 usecs_to_jiffies(ctx->usecs_lat))) {
ed42cfa881e1d8 hotran 2016-07-21 161 dev_err(ctx->dev, "Mailbox operation timed out\n");
ed42cfa881e1d8 hotran 2016-07-21 162 rc = -ETIMEDOUT;
ed42cfa881e1d8 hotran 2016-07-21 163 goto err;
ed42cfa881e1d8 hotran 2016-07-21 164 }
ed42cfa881e1d8 hotran 2016-07-21 165
ed42cfa881e1d8 hotran 2016-07-21 166 /* Check for error message */
ed42cfa881e1d8 hotran 2016-07-21 167 if (MSG_TYPE(ctx->sync_msg.msg) == MSG_TYPE_ERR) {
ed42cfa881e1d8 hotran 2016-07-21 168 rc = -EINVAL;
ed42cfa881e1d8 hotran 2016-07-21 169 goto err;
ed42cfa881e1d8 hotran 2016-07-21 170 }
ed42cfa881e1d8 hotran 2016-07-21 171
ed42cfa881e1d8 hotran 2016-07-21 172 msg[0] = ctx->sync_msg.msg;
ed42cfa881e1d8 hotran 2016-07-21 173 msg[1] = ctx->sync_msg.param1;
ed42cfa881e1d8 hotran 2016-07-21 174 msg[2] = ctx->sync_msg.param2;
ed42cfa881e1d8 hotran 2016-07-21 175
ed42cfa881e1d8 hotran 2016-07-21 176 err:
ed42cfa881e1d8 hotran 2016-07-21 177 mbox_chan_txdone(ctx->mbox_chan, 0);
ed42cfa881e1d8 hotran 2016-07-21 178 ctx->resp_pending = false;
ed42cfa881e1d8 hotran 2016-07-21 179 mutex_unlock(&ctx->rd_mutex);
ed42cfa881e1d8 hotran 2016-07-21 180 return rc;
ed42cfa881e1d8 hotran 2016-07-21 181 }
ed42cfa881e1d8 hotran 2016-07-21 182
:::::: The code at line 145 was first introduced by commit
:::::: c7cefce03e691270c0e5e117248e14661e9c9cad hwmon: (xgene) access mailbox as RAM
:::::: TO: Arnd Bergmann <arnd@...db.de>
:::::: CC: Guenter Roeck <linux@...ck-us.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists