linux-kernel - Re: [PATCH] iommu/dart: add missing put_device() call in apple_dart_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fb8863d-24eb-46c5-b52c-20313eeba5f5@web.de>
Date: Sat, 12 Jul 2025 20:22:13 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhang Shurong <zhang_shurong@...mail.com>, asahi@...ts.linux.dev,
 iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Janne Grunau <j@...nau.net>,
 Jörg Rödel <joro@...tes.org>, Neal Gompa <neal@...pa.dev>,
 Robin Murphy <robin.murphy@....com>, Sven Peter <sven@...nel.org>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH] iommu/dart: add missing put_device() call in
 apple_dart_of_xlate

> The apple_dart_of_xlate() function obtains a platform device reference
> via of_find_device_by_node() but doesn't release it with put_device().
> This patch adds proper device reference handling to prevent memory
> leaks.

Will another goto chain become helpful here?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc5#n94


Under which circumstances can the application of the attribute “put_device” grow?
https://elixir.bootlin.com/linux/v6.16-rc5/source/include/linux/device.h#L1140

Regards,
Markus