linux-kernel - Re: of xvip_enum_frame_size and xvip_get_format_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHQ_-TCl02_mcHHz@gallifrey>
Date: Sun, 13 Jul 2025 23:23:37 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: mchehab@...nel.org, michal.simek@....com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: of xvip_enum_frame_size and xvip_get_format_by_code

* Laurent Pinchart (laurent.pinchart@...asonboard.com) wrote:
> On Sun, Jul 13, 2025 at 04:51:08PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> >   I noticed in xilinx-cip.c there's xvip_enum_frame_size()
> > which was added back in 2013 but seems unused in tree, however
> > I had a dig and I found
> >   https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841638/Xilinx+V4L2+TPG+driver
> > has a commit:
> >   https://github.com/Xilinx/linux-xlnx/commit/1c113b4aef14004152fefc0e8b8dbbcc2314566f#diff-bb594682a92148570df8826933cf8629
> >   from 2014 that uses it - but it looks like that commit never went
> > anywhere.
> > 
> > So is xvip_enum_frame_size() or not?
> > I also see xvip_get_format_by_code() looks unused, but I don't
> > see any uses of it, even digging in that wiki.
> 
> Those functions seem to have never been used in the mainline kernel.
> They were likely added to support drivers that have not been upstreamed.

Ah, shame.

> Both functions are used in the Xilinx BSP kernel.

OK, I'll stay clear.

Dave

> -- 
> Regards,
> 
> Laurent Pinchart
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/