linux-kernel - Re: [PATCH] tools/libbpf: add WERROR option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikjwobkz.fsf@gentoo.org>
Date: Sun, 13 Jul 2025 07:21:16 +0100
From: Sam James <sam@...too.org>
To: Quentin Monnet <qmo@...nel.org>
Cc: Daniel Borkmann <daniel@...earbox.net>,  bpf@...r.kernel.org,  Andrii
 Nakryiko <andrii@...nel.org>,  Eduard Zingerman <eddyz87@...il.com>,
  Alexei Starovoitov <ast@...nel.org>,  Martin KaFai Lau
 <martin.lau@...ux.dev>,  Song Liu <song@...nel.org>,  Yonghong Song
 <yonghong.song@...ux.dev>,  John Fastabend <john.fastabend@...il.com>,  KP
 Singh <kpsingh@...nel.org>,  Stanislav Fomichev <sdf@...ichev.me>,  Hao
 Luo <haoluo@...gle.com>,  Jiri Olsa <jolsa@...nel.org>,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/libbpf: add WERROR option

Quentin Monnet <qmo@...nel.org> writes:

> 2025-07-07 15:18 UTC+0200 ~ Daniel Borkmann <daniel@...earbox.net>
>> On 7/5/25 12:43 PM, Sam James wrote:
>>> Check the 'WERROR' variable and suppress adding '-Werror' if WERROR=0.
>>>
>>> This mirrors what tools/perf and other directories in tools do to handle
>>> -Werror rather than adding it unconditionally.
>> 
>> Could you also add to the commit desc why you need it? Are there particular
>> warnings you specifically need to suppress when building under gentoo?
>
>
> And if you need to disable the flag on a particular target, have you
> considered using the existing variables and pass EXTRA_CFLAGS=-Wno-error
> rather than adding another flag?

I think inconsistency with other tools/ is unfortunate, but yes, I guess
we could.

>
> Quentin