linux-kernel - Re: [PATCH v7 8/9] fbcon: Use screen info to find primary device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507142313.iWVTOSVB-lkp@intel.com>
Date: Mon, 14 Jul 2025 23:12:41 +0800
From: kernel test robot <lkp@...el.com>
To: Mario Limonciello <superm1@...nel.org>,
	David Airlie <airlied@...il.com>,
	Bjorn Helgaas <helgaas@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	Simona Vetter <simona@...ll.ch>, Lukas Wunner <lukas@...ner.de>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Woodhouse <dwmw2@...radead.org>,
	Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	"(open list:INTEL IOMMU (VT-d))" <iommu@...ts.linux.dev>,
	linux-pci@...r.kernel.org, kvm@...r.kernel.org,
	linux-sound@...r.kernel.org, Daniel Dadap <ddadap@...dia.com>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v7 8/9] fbcon: Use screen info to find primary device

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus tiwai-sound/for-next tiwai-sound/for-linus tip/x86/core linus/master v6.16-rc6 next-20250714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/PCI-Add-helper-for-checking-if-a-PCI-device-is-a-display-controller/20250706-223745
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250706143613.1972252-9-superm1%40kernel.org
patch subject: [PATCH v7 8/9] fbcon: Use screen info to find primary device
config: i386-randconfig-053-20250714 (https://download.01.org/0day-ci/archive/20250714/202507142313.iWVTOSVB-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250714/202507142313.iWVTOSVB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507142313.iWVTOSVB-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: arch/x86/video/video-common.o: in function `video_is_primary_device':
>> arch/x86/video/video-common.c:45: undefined reference to `screen_info_pci_dev'


vim +45 arch/x86/video/video-common.c

    28	
    29	bool video_is_primary_device(struct device *dev)
    30	{
    31		struct screen_info *si = &screen_info;
    32		struct pci_dev *pdev;
    33	
    34		if (!dev_is_pci(dev))
    35			return false;
    36	
    37		pdev = to_pci_dev(dev);
    38	
    39		if (!pci_is_display(pdev))
    40			return false;
    41	
    42		if (pdev == vga_default_device())
    43			return true;
    44	
  > 45		if (pdev == screen_info_pci_dev(si))
    46			return true;
    47	
    48		return false;
    49	}
    50	EXPORT_SYMBOL(video_is_primary_device);
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki