linux-kernel - Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHUhLSDQ/vdrg3hX@lizhi-Precision-Tower-5810>
Date: Mon, 14 Jul 2025 11:24:29 -0400
From: Frank Li <Frank.li@....com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Animesh Agarwal <animeshagarwal28@...il.com>,
	"open list:CLOCKSOURCE, CLOCKEVENT DRIVERS" <linux-kernel@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for
 reg

On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
> The original txt binding doc is:
>   reg : Specifies base physical address and size of the register sets for
>         the clock event device and clock source device.
>
> And existed dts provide two reg MMIO spaces. So change to use items to
> descript reg property.
>
> Update examples.
>
> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Frank Li <Frank.Li@....com>

Daniel Lezcano Or Rob

Krzysztof Kozlowski already reviewed. Could you place pick this one?

Frank

> ---
> change in v2
> - add kk review tag
> - add missed )
> ---
>  Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> index 0e4a8ddc3de32..e3b61b62521e8 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> @@ -14,7 +14,9 @@ properties:
>      const: fsl,ftm-timer
>
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: clock event device
> +      - description: clock source device
>
>    interrupts:
>      maxItems: 1
> @@ -50,7 +52,8 @@ examples:
>
>      ftm@...b8000 {
>          compatible = "fsl,ftm-timer";
> -        reg = <0x400b8000 0x1000>;
> +        reg = <0x400b8000 0x1000>,
> +              <0x400b9000 0x1000>;
>          interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
>          clock-names = "ftm-evt", "ftm-src", "ftm-evt-counter-en", "ftm-src-counter-en";
>          clocks = <&clks VF610_CLK_FTM2>, <&clks VF610_CLK_FTM3>,
> --
> 2.34.1
>